> On June 24, 2016, 1:43 a.m., Guangya Liu wrote: > > @Gilbert, I saw that there is no test case for containers without rootfs > > against your code change, are you planning to add those cases in this patch > > chain?
Thanks for pointing that out. I considered whether adding those tests or not. But the logic here seems to me that tests `with rootfs` should cover cases `without rootfs`, so I prefer not to create redundancies. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49184/#review139359 ----------------------------------------------------------- On June 23, 2016, 11:28 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49184/ > ----------------------------------------------------------- > > (Updated June 23, 2016, 11:28 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, Timothy Chen, and Jiang > Yan Xu. > > > Bugs: MESOS-5697 > https://issues.apache.org/jira/browse/MESOS-5697 > > > Repository: mesos > > > Description > ------- > > Implemented file volume support in mesos containerizer. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > adacde191132a7a92c1fdf27ef8a4a41d2afa003 > > Diff: https://reviews.apache.org/r/49184/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
