> On June 24, 2016, 8:49 p.m., Vinod Kone wrote: > > include/mesos/mesos.proto, lines 2038-2054 > > <https://reviews.apache.org/r/49214/diff/1/?file=1429888#file1429888line2038> > > > > are all these available on all tye OSses we support? OSX, Windows and > > Linux? If not, some of these might have to be optional.
Good point. I had ignored Windows completely, my bad. I made everything `optional` except the absolute `path` that seems to be omnipresent. `size` was a contentious one and some distros deal with sizes of links differently. Hence, I kept it as `optional` too. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49214/#review139400 ----------------------------------------------------------- On June 24, 2016, 7:52 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49214/ > ----------------------------------------------------------- > > (Updated June 24, 2016, 7:52 p.m.) > > > Review request for mesos, Abhishek Dasgupta, zhou xing, and Vinod Kone. > > > Bugs: MESOS-5514 > https://issues.apache.org/jira/browse/MESOS-5514 > > > Repository: mesos > > > Description > ------- > > This change would be needed later for implementing the `LIST_FILES` > call for the Master/Agent v1 API. > > > Diffs > ----- > > include/mesos/mesos.proto 8a417f91ca6771b971cf5ee50351171412163f7a > include/mesos/v1/mesos.proto 3bc65e7fb1b34651bf025711023f9e219928040a > > Diff: https://reviews.apache.org/r/49214/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
