----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49118/#review139432 -----------------------------------------------------------
Patch looks great! Reviews applied: [48902, 49118] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 24, 2016, 4:06 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49118/ > ----------------------------------------------------------- > > (Updated June 24, 2016, 4:06 p.m.) > > > Review request for mesos, Joris Van Remoortere and Vinod Kone. > > > Bugs: MESOS-5642 > https://issues.apache.org/jira/browse/MESOS-5642 > > > Repository: mesos > > > Description > ------- > > This is the second part of moving allocator to own package: > 1. Move the non-versioned allocator.proto and allocator.hpp; > 2. Move namespace of `Allocator` base class; > 3. Fix allocation-module.md; > 4. Call out allocator api change in docs/upgrades.md. > > > Diffs > ----- > > CHANGELOG c987d1936c6c6c8ef9da04778a7271c66eb22c52 > docs/allocation-module.md 6cb1392aff9eeb5cb4a8f14c91df50f29d25948c > docs/upgrades.md be3bd27f0cf9aa3bd10ca481187553278ec79914 > include/mesos/maintenance/maintenance.proto > 458b42733fe7cb83dd43e5daf239929bea6fcb41 > include/mesos/master/allocator.hpp a4743c5a31b18d96722a42d526bfb669d30e6e48 > include/mesos/master/allocator.proto > 8252abf47a19d5cc6c581c446b8756648fb2a054 > include/mesos/module/allocator.hpp 5e65e69b6d62611f51e85aa9adaa283713896d4c > src/CMakeLists.txt ecdeee75abfca944bc2ac1da4962d8d50e236d2d > src/Makefile.am 23cac95a805e46d216e9479fea09f2c1619c45a5 > src/examples/test_allocator_module.cpp > bc28eb4146d4cfe1c3e04302eaa4f3f4ac91c4eb > src/local/local.hpp 0c86f97dc7c1a4ee7fe49c457de051eab03d5117 > src/local/local.cpp b40ca7c0bc44561ba56baa3499e124f5a75a9489 > src/master/allocator/allocator.cpp 8e76a3a33efd896a21960b0092dfdee800d211f5 > src/master/allocator/mesos/allocator.hpp > 64bce0fb143b109c26f923cd97d5facb393dee9d > src/master/allocator/mesos/hierarchical.hpp > c9cb1e114ad3407f86799c533fd6ae9c459f9062 > src/master/allocator/mesos/hierarchical.cpp > 5b2331b3f99252fd16f2514123006dd4ba7f1c0d > src/master/http.cpp 837fba661a82d07e95bc2de6d08158002147131a > src/master/main.cpp 01c827625927ed6b9d2dc6f2c4d8e7bd1b45677c > src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa > src/master/master.cpp d89c049326358bad509bb1455c81eb11610eeeb8 > src/tests/allocator.hpp 4081193abed29b99f60254e98ef9ebc981bde859 > src/tests/cluster.hpp 3b37f963400eaea9f7489d182ce024b43f7db874 > src/tests/cluster.cpp f25b887d8a5b805e61640630f6f26f905f6c4f03 > src/tests/fault_tolerance_tests.cpp > 5109b8310871c2b4efe209b3d6fcce1b803af788 > src/tests/hierarchical_allocator_tests.cpp > 6de0702f1960677abf9fd458576f7400a938cbb0 > src/tests/master_allocator_tests.cpp > 0425266abd70f52f1c6c4fc294bfbcfb0b0df4df > src/tests/master_authorization_tests.cpp > 9ae6b9dc89538716d397ffd8826187e2bc6d7e8f > src/tests/master_maintenance_tests.cpp > b1043852a1618c5e2deafdc5437184ab593f1361 > src/tests/master_slave_reconciliation_tests.cpp > f67bfd2ceec6303cfac5782417e824bfae7ca665 > src/tests/master_tests.cpp ce9c192ce29ea6e1b3757f4b7459e7f92bb16389 > src/tests/mesos.hpp bcd060ec07da27db8738950bd81ead37da11ee70 > src/tests/mesos.cpp 6918343b13a735aec243b54a9fcbced056894f53 > src/tests/rate_limiting_tests.cpp 5d68ac170cb5a948df1429ffbf8e5b8f02f708d9 > src/tests/reservation_tests.cpp 2cc352d230f5ba8ca15698b09a44377c6af53913 > > Diff: https://reviews.apache.org/r/49118/diff/ > > > Testing > ------- > > `make && make check` on mac. > > > Thanks, > > Zhitao Li > >
