----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review139676 -----------------------------------------------------------
Fix it, then Ship it! can you rebase? src/master/http.cpp (line 1706) <https://reviews.apache.org/r/48438/#comment204973> new line here. src/master/http.cpp (line 1719) <https://reviews.apache.org/r/48438/#comment204969> why pull this into a variable? - Vinod Kone On June 27, 2016, 9:03 a.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48438/ > ----------------------------------------------------------- > > (Updated June 27, 2016, 9:03 a.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: mesos-5491 > https://issues.apache.org/jira/browse/mesos-5491 > > > Repository: mesos > > > Description > ------- > > Implement the basic getAgents method for v1 operator master API. > > > Diffs > ----- > > src/master/http.cpp d55aa05c76bb2b1fb17b795510fd50c021cdb995 > src/master/master.hpp 648f1a217cc7bbb154a9d7a2a8b2c5d02087af03 > src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb > > Diff: https://reviews.apache.org/r/48438/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > zhou xing > >
