----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49319/#review139796 -----------------------------------------------------------
include/mesos/authorizer/authorizer.proto (lines 90 - 91) <https://reviews.apache.org/r/49319/#comment205142> This comment is rather incomplete: 1. Either they are both set or none. 2. When none are set it is because the task has not yet created the directory (because is scheduled) or it is finished and there was a lag between access and destruction of the enpoint. All in all, we should mention that having none set is an exceptional case, and could be treated by returning an error. - Alexander Rojas On June 28, 2016, 4:35 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49319/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 4:35 p.m.) > > > Review request for mesos, Adam B and Alexander Rojas. > > > Bugs: MESOS-5730 > https://issues.apache.org/jira/browse/MESOS-5730 > > > Repository: mesos > > > Description > ------- > > The current semantic is that these fields might not be set. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.proto > fc76796022a6fa3d36a1447c476980868d42c2d0 > > Diff: https://reviews.apache.org/r/49319/diff/ > > > Testing > ------- > > > Thanks, > > Joerg Schad > >
