-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48374/
-----------------------------------------------------------
(Updated June 29, 2016, 12:25 a.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Rebased
Bugs: MESOS-5562
https://issues.apache.org/jira/browse/MESOS-5562
Repository: mesos
Description (updated)
-------
Previously, the `NvidiaGpuAllocator` component was created directly
inside the `NvidiaGpuIsolatorProcess` even though it was designed to
be used by multiple containerizers at the same time. To allow for
simultaneous access, we created a new `NvidiaComponents` class to hold
an `NvidiaGpuAllocator` instance and pass it to each containerizer as
it is created. This component can easily be extended to include more
cross-containerizer components later on.
We create the `NvidiaComponents` instance inside
`Containerizer::create()` and pass it to both the docker containerizer
and the mesos containerizer when they are created. The docker
containerizer currently doesn't do anything with this information, but
its interface has been updated to accomodate it. The mesos
containerizer has been updated to pass this all the way down to the
`NvidiaGpuIsolatorProcess` and exploit it.
Diffs (updated)
-----
src/Makefile.am 86c39fdf379ada470c9b1f86be263ef71dc47c41
src/slave/containerizer/containerizer.cpp
2449526061f7d6ac46ff42260ccdd0278694d9d4
src/slave/containerizer/docker.hpp 9b0a5a76e457006119e657ee8f627dcd1326c0ce
src/slave/containerizer/docker.cpp 514268fd84507eafa11fc57d38a23b0502f80ef8
src/slave/containerizer/mesos/containerizer.hpp
a1a00020668f6da8d611f26e5637afffc87d09ba
src/slave/containerizer/mesos/containerizer.cpp
d984efd4742ec084d66538c48a36ea768832324d
src/slave/containerizer/mesos/isolators/gpu/components.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/gpu/nvidia.hpp
e35a55fdf44ec01d49d6a9e396a88f4163ef79c3
src/slave/containerizer/mesos/isolators/gpu/nvidia.cpp
b8753ec8fc0afc8f2b389250de57d5095287acf9
Diff: https://reviews.apache.org/r/48374/diff/
Testing
-------
GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests
Thanks,
Kevin Klues
