> On 六月 29, 2016, 4:59 p.m., Klaus Ma wrote: > > src/common/parse.hpp, lines 150-152 > > <https://reviews.apache.org/r/49352/diff/1/?file=1432428#file1432428line150> > > > > Call `insert` directly should be fine. `set` will help to avoid > > duplicated item.
Here I need to return error if there are diplicate items, seems I cannot use `set` for this as `set` do not have a method like `contain` which can enable me to check the duplicate items, comments? - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49352/#review140009 ----------------------------------------------------------- On 六月 29, 2016, 12:12 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49352/ > ----------------------------------------------------------- > > (Updated 六月 29, 2016, 12:12 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5743 > https://issues.apache.org/jira/browse/MESOS-5743 > > > Repository: mesos > > > Description > ------- > > Added a flag parser for hashset<std::string>. > > > Diffs > ----- > > src/common/parse.hpp 19e56dbeb765f8bec92e0a3615f6f7c12466fa9e > > Diff: https://reviews.apache.org/r/49352/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
