> On June 30, 2016, 4:03 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/tests/ssl_tests.cpp, lines 781-783 > > <https://reviews.apache.org/r/49402/diff/1/?file=1433269#file1433269line781> > > > > Let's parameterize the existing tests these are copied from since the > > logical behavior doesn't change.
Great idea - should have had it myself when feeling icky about a complete copy&paste - thanks! - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49402/#review140177 ----------------------------------------------------------- On June 30, 2016, 12:19 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49402/ > ----------------------------------------------------------- > > (Updated June 30, 2016, 12:19 a.m.) > > > Review request for mesos, Adam B, Albert Strasheim, Artem Harutyunyan, Joris > Van Remoortere, and Lukas Loesche. > > > Bugs: MESOS-5724 > https://issues.apache.org/jira/browse/MESOS-5724 > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/ssl_tests.cpp > cf0119d1266cb81aa5fc7a86e034ba302892d44f > > Diff: https://reviews.apache.org/r/49402/diff/ > > > Testing > ------- > > make check on OSX and various linux distros. > > > Thanks, > > Till Toenshoff > >