----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49448/#review140250 -----------------------------------------------------------
LGTM! - Can we add a test for the unhappy case too i.e. `BadRequest`/`InternalServerError` on either of master/agent? - Similar comments as for the Master test also apply to the agent test. I did not duplicate the comments. include/mesos/v1/mesos.hpp (line 55) <https://reviews.apache.org/r/49448/#comment205599> These should be part of a separate review since these are not related to adding tests. src/internal/evolve.hpp (line 72) <https://reviews.apache.org/r/49448/#comment205600> These should be part of a separate review since these are not related to adding tests. src/tests/api_tests.cpp (line 514) <https://reviews.apache.org/r/49448/#comment205604> s/correct file information in a specified path/file listing for a directory src/tests/api_tests.cpp (line 519) <https://reviews.apache.org/r/49448/#comment205602> hmm, why do you need this? src/tests/api_tests.cpp (line 527) <https://reviews.apache.org/r/49448/#comment205609> Missing backticks around `FileInfo`. s/FileInfo message for a/`FileInfo` for s/a specified path/"1/two" file. Ditto for the agent test. src/tests/api_tests.cpp (line 532) <https://reviews.apache.org/r/49448/#comment205610> Nit: `this->` looks redundant. Just `StartMaster` should suffice? src/tests/api_tests.cpp (line 549) <https://reviews.apache.org/r/49448/#comment205612> Align with `internal::evolve` - Anand Mazumdar On June 30, 2016, 2:07 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49448/ > ----------------------------------------------------------- > > (Updated June 30, 2016, 2:07 p.m.) > > > Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, and > Vinod Kone. > > > Bugs: MESOS-5514 > https://issues.apache.org/jira/browse/MESOS-5514 > > > Repository: mesos > > > Description > ------- > > Added testcases for LIST_FILES call. > > > Diffs > ----- > > include/mesos/v1/mesos.hpp d220966bb9464595c927474532ccdcaf41690ef6 > src/internal/evolve.hpp 582f3476d0f61c9356cf5aff5f242f3e8103822d > src/internal/evolve.cpp bb99cb29db84e5476a820b261ff24348c657bae0 > src/tests/api_tests.cpp b3127b716480223a6f23b7908bf6bc1808120f80 > src/v1/mesos.cpp 30788dcc1dd744553ddd93d23b11fcce44502b46 > > Diff: https://reviews.apache.org/r/49448/diff/ > > > Testing > ------- > > On Ubuntu 16.04: > sudo > GTEST_FILTER="*AgentAPITest.ListFiles*:FilesTest.BrowseTest:*MasterAPITest.ListFiles*" > make -j4 check > > > Thanks, > > Abhishek Dasgupta > >
