----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49545/#review140504 -----------------------------------------------------------
Assuming we still want to have the `.string()` function on the `Path` class, this patch looks fine. I still think casting to a string seems cleaner than having a member function called `.string()` though. - Kevin Klues On July 2, 2016, 12:55 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49545/ > ----------------------------------------------------------- > > (Updated July 2, 2016, 12:55 a.m.) > > > Review request for mesos and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > Updated code to use Path::string() instead of Path::value. > > > Diffs > ----- > > src/credentials/credentials.hpp 253ea8353ac67fde40268e35ea16f773f11eb509 > src/linux/systemd.cpp 3e1ba935763383ba5d5bf9fad21a948a771101a0 > src/slave/containerizer/fetcher.cpp > 7b52cb1703e5b8a6ce0e995896fab3cd520a5090 > src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp > b29fc79de7f1915778e43a7f4e72c2754bb64ab3 > src/slave/containerizer/mesos/provisioner/provisioner.cpp > 249acad49122d988e44744384bcf840b941c0997 > src/tests/common/command_utils_tests.cpp > c91a7f38263e4c8352ec56f79070baec2b1cb06f > src/tests/fetcher_cache_tests.cpp ba7d3f84ee54d982d7dfe0eeb9c67c1a68f9cf40 > src/watcher/whitelist_watcher.cpp b252f2f1b35113996f72c2ff92bcd6a3728d02f9 > > Diff: https://reviews.apache.org/r/49545/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
