----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49562/#review140511 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/elf.hpp (lines 20 - 24) <https://reviews.apache.org/r/49562/#comment205916> Looks like we can remove a bunch of these? 3rdparty/stout/include/stout/elf.hpp (line 66) <https://reviews.apache.org/r/49562/#comment205917> whoops, brace on the next line here and above 3rdparty/stout/include/stout/elf.hpp (line 76) <https://reviews.apache.org/r/49562/#comment205914> Unfortunately, it doesn't seem that there is any contract around using errno for errors, so let's avoid assuming this (in case we end up with incorrect error messages). :( 3rdparty/stout/include/stout/elf.hpp (line 104) <https://reviews.apache.org/r/49562/#comment205915> Seems this should maybe be a None? I'll leave as is for now. - Benjamin Mahler On July 2, 2016, 7:31 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49562/ > ----------------------------------------------------------- > > (Updated July 2, 2016, 7:31 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5768 > https://issues.apache.org/jira/browse/MESOS-5768 > > > Repository: mesos > > > Description > ------- > > As part of this, we updated the API to include functions written in > snake_case (as is standard for stout). We also removed the 'close()' > call, as the new ELFIO library doesn't require it. > > > Diffs > ----- > > 3rdparty/stout/include/stout/elf.hpp > 5382acc1c12901ce8d8256f6010f48579020fbca > > Diff: https://reviews.apache.org/r/49562/diff/ > > > Testing > ------- > > Tests coming in subsequent patch with updates to `ldcache_tests.cpp` > > > Thanks, > > Kevin Klues > >
