----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49323/#review140655 -----------------------------------------------------------
Ship it! Ship It! - Michael Park On July 4, 2016, 8:32 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49323/ > ----------------------------------------------------------- > > (Updated July 4, 2016, 8:32 a.m.) > > > Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, and > Michael Park. > > > Bugs: MESOS-5698 > https://issues.apache.org/jira/browse/MESOS-5698 > > > Repository: mesos > > > Description > ------- > > These tests check that dynamic reservations and persistent volumes can > be created via the offer API and then removed via the HTTP endpoints, > and vice versa. > > > Diffs > ----- > > src/tests/persistent_volume_endpoints_tests.cpp > 971a7b38d26b26c8543815e467f30cbb83ee412c > > Diff: https://reviews.apache.org/r/49323/diff/ > > > Testing > ------- > > make check > > This test passes without any Mesos changes. i.e., it doesn't reproduce the > bug by itself, but having more test coverage for this scenario seems wise. > > > Thanks, > > Neil Conway > >