----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review140714 -----------------------------------------------------------
src/tests/hierarchical_allocator_tests.cpp (line 3617) <https://reviews.apache.org/r/49616/#comment206065> I think that it is better move this test case above `HierarchicalAllocator_BENCHMARK_Test, Metrics` Also what about rename this test case as `HierarchicalAllocator_BENCHMARK_Test, SuppressOffers` src/tests/hierarchical_allocator_tests.cpp (line 3674) <https://reviews.apache.org/r/49616/#comment206063> kill this line src/tests/hierarchical_allocator_tests.cpp (line 3711) <https://reviews.apache.org/r/49616/#comment206067> Not yours, but I think that it is better use `batch allocation` here instead of `background allocation` - Guangya Liu On 七月 4, 2016, 11:18 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49616/ > ----------------------------------------------------------- > > (Updated 七月 4, 2016, 11:18 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > - Useful for high framework clusters which carry > many suppressed frameworks that are considered > during allocation. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 0498cd5e54b0e4b87a767585a77699653aa52179 > > Diff: https://reviews.apache.org/r/49616/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jacob Janco > >
