----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49661/#review140886 -----------------------------------------------------------
Do you think we should add a failure handler to the docker executor? i.e. https://github.com/apache/mesos/blob/def697929f5029832cd2895da38565e52a9882ec/src/docker/executor.cpp#L178 ``` inspect = docker->inspect(containerName, DOCKER_INSPECT_DELAY) .onFailed([](const std::string& message) { LOG(INFO) << "Inspect failed with : " << message; }) ``` src/docker/docker.cpp (line 241) <https://reviews.apache.org/r/49661/#comment206229> It won't be possible/straightfoward to make a protobuf schema for this method afterwards :( The type is Null || Array ): - Joseph Wu On July 5, 2016, 3:15 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49661/ > ----------------------------------------------------------- > > (Updated July 5, 2016, 3:15 p.m.) > > > Review request for mesos, Gilbert Song and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > This now contains an empty array when no devices are present. > However, it appears that Docker previously used null entries > to represent the same scenario. > > > Diffs > ----- > > src/docker/docker.cpp aad5380f5848f1b49d5524032f3b5b18c2aa1c56 > > Diff: https://reviews.apache.org/r/49661/diff/ > > > Testing > ------- > > sudo ./bin/mesos-tests.sh --gtest_filter="*DockerTest.*" > > > Thanks, > > Benjamin Mahler > >
