> On July 6, 2016, 12:30 a.m., Anand Mazumdar wrote: > > src/tests/api_tests.cpp, line 537 > > <https://reviews.apache.org/r/49517/diff/4/?file=1436046#file1436046line537> > > > > Just execDriver->sendXX would suffice. > > > > Would be a good idea to do a sweep across this file and remove the > > redundant `get()` in favor of the `->` operator.
I think we need at least one `get()` here, because type of `execDriver` is a Future? - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49517/#review140901 ----------------------------------------------------------- On July 4, 2016, 4:05 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49517/ > ----------------------------------------------------------- > > (Updated July 4, 2016, 4:05 a.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: MESOS-5489 > https://issues.apache.org/jira/browse/MESOS-5489 > > > Repository: mesos > > > Description > ------- > > The help function will also be used for snapshot of > event stream. > > > Diffs > ----- > > src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe > src/master/master.hpp be7cd239c49a0710a29a8187c01484f9f6d615e1 > src/tests/api_tests.cpp e2d8bf591667ec9d8c609e55a424b55561892b5f > > Diff: https://reviews.apache.org/r/49517/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Zhitao Li > >
