----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49516/#review140950 -----------------------------------------------------------
Fix it, then Ship it! Would fix these minor style nits while committing. src/master/http.cpp (line 1426) <https://reviews.apache.org/r/49516/#comment206322> new line before to be consistent with `getTasks()`. src/master/http.cpp (line 1466) <https://reviews.apache.org/r/49516/#comment206323> s/mesos::master::Response::GetExecutors/Future<mesos::master::Response::GetExecutors> - Anand Mazumdar On July 6, 2016, 1:47 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49516/ > ----------------------------------------------------------- > > (Updated July 6, 2016, 1:47 a.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: MESOS-5489 > https://issues.apache.org/jira/browse/MESOS-5489 > > > Repository: mesos > > > Description > ------- > > Helper function will be reused by `GetExecutors` and `GetState`. > > > Diffs > ----- > > src/master/http.cpp debedd4a4061034a3b55181e93443b9d5e676c52 > src/master/master.hpp 996ff425fc8e9234a5e02560460ad1233dca7061 > > Diff: https://reviews.apache.org/r/49516/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Zhitao Li > >
