----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49509/#review140948 -----------------------------------------------------------
Fix it, then Ship it! Would fix this before committing. include/mesos/master/master.proto (line 272) <https://reviews.apache.org/r/49509/#comment206319> I added a bit more meat to the comment. // Contains full state of the master i.e. information about the tasks, agents, frameworks and executors running in the cluster. - Anand Mazumdar On July 6, 2016, 1:46 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49509/ > ----------------------------------------------------------- > > (Updated July 6, 2016, 1:46 a.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: MESOS-5489 > https://issues.apache.org/jira/browse/MESOS-5489 > > > Repository: mesos > > > Description > ------- > > Revised protobuf definition of GetState response. > > > Diffs > ----- > > include/mesos/master/master.proto d06258e9fd39c7eefd8ecd394e3bdfb888479b1e > include/mesos/v1/master/master.proto > b7cb6fdf2e4f34a11d326ac3ad3ec26525f8f343 > > Diff: https://reviews.apache.org/r/49509/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Zhitao Li > >