----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49610/#review141008 -----------------------------------------------------------
Fix it, then Ship it! Thanks a lot for the test Neil! It looks like we should not rely in the stripped resources in https://github.com/apache/mesos/blob/149f4c55b951e5eaea1cb5faf400089dd36c355a/src/master/allocator/mesos/hierarchical.cpp#L1378. It looks like we should add `totalResources()` into the allocator and use it instead. It should be safe to strip the role in the sorters afterwards. Generally, it looks like we should not leverage sorter as source of truth for bookkeeping resources. src/tests/hierarchical_allocator_tests.cpp (line 2441) <https://reviews.apache.org/r/49610/#comment206385> Mind mentioning that resources are declined for a prolongued time? src/tests/hierarchical_allocator_tests.cpp (lines 2451 - 2452) <https://reviews.apache.org/r/49610/#comment206383> I believe you want to advance the clock here for one interval, no? src/tests/hierarchical_allocator_tests.cpp (line 2464) <https://reviews.apache.org/r/49610/#comment206384> Mind mentioning that resources are declined for a prolongued time here as well? - Alexander Rukletsov On July 5, 2016, 8:51 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49610/ > ----------------------------------------------------------- > > (Updated July 5, 2016, 8:51 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > This test checks that when setting aside unallocated resources to ensure > that a quota guarantee can be met, we don't use resources that have been > reserved for a different role. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 0498cd5e54b0e4b87a767585a77699653aa52179 > > Diff: https://reviews.apache.org/r/49610/diff/ > > > Testing > ------- > > `./src/mesos-tests > --gtest_filter="HierarchicalAllocatorTest.QuotaSetAsideReservedResources" > --gtest_repeat=500 --gtest_break_on_failure` passes. When you apply a patch > that breaks quota allocation behavior > (https://gist.github.com/neilconway/97eed34e9b0b312b8511f0f4f57fe061), > previously `make check` passes, but it fails with this new test added. > > > Thanks, > > Neil Conway > >
