----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49652/#review141053 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp (line 1058) <https://reviews.apache.org/r/49652/#comment206431> Should we check for DESTROYING here? src/slave/containerizer/mesos/containerizer.cpp (lines 1354 - 1356) <https://reviews.apache.org/r/49652/#comment206432> In fact, we should check for `contains` and `DESTROYING` as well because the container logger stuff made isolate async - Jie Yu On July 6, 2016, 5:09 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49652/ > ----------------------------------------------------------- > > (Updated July 6, 2016, 5:09 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Bugs: MESOS-5763 > https://issues.apache.org/jira/browse/MESOS-5763 > > > Repository: mesos > > > Description > ------- > > One of the reasons for MESOS-5763 is due to the lack invariant > checking. Mesos containerizer transitions the container state in > particular ways so when continuation chains could potentially be > interleaved with other actions we should verify the state transitions. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > f53b01b0eef8dd24db28d9dbd86bcbd40dc8d17f > > Diff: https://reviews.apache.org/r/49652/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
