> On July 6, 2016, 4:19 p.m., Jiang Yan Xu wrote: > > > > Guangya Liu wrote: > @Jiang Yan, just FYI, I filed a JIRA here > https://issues.apache.org/jira/browse/MESOS-5800 to trace the comments you > mentioned here for other benchmark test.
Thanks! > On July 6, 2016, 4:19 p.m., Jiang Yan Xu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3609-3616 > > <https://reviews.apache.org/r/49616/diff/2/?file=1437089#file1437089line3609> > > > > We can simply: > > > > ``` > > cout << "Using " << slaveCount << " agents and " > > << frameworkCount << " frameworks" << endl; > > > > vector<SlaveInfo> slaves(slaveCount); > > vector<FrameworkInfo> frameworks(frameworkCount); > > ``` > > Guangya Liu wrote: > I think that you did not address this comment but still using > `vector<FrameworkInfo> frameworks;`. We cannot use `vector<FrameworkInfo> > frameworks(frameworkCount);` here, as the `vector<FrameworkInfo> > frameworks(frameworkCount);` will create some empty frameworks and when > allocator add frameworks, we will get segment fault as `F0707 22:26:05.169266 > 25663 hierarchical.cpp:242] Check failed: > !frameworkSorters[role]->contains(frameworkId.value())`. Hey Guangya, thanks for pointing this out. It's my fault for suggesting `vector<SlaveInfo> slaves(slaveCount)` which is actually a "fill constructor". We still have to use `reserve()`. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review141095 ----------------------------------------------------------- On July 7, 2016, 8:48 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49616/ > ----------------------------------------------------------- > > (Updated July 7, 2016, 8:48 p.m.) > > > Review request for mesos, James Peach, Joris Van Remoortere, and Jiang Yan Xu. > > > Bugs: MESOS-5781 > https://issues.apache.org/jira/browse/MESOS-5781 > > > Repository: mesos > > > Description > ------- > > - Useful for high framework clusters which carry > many suppressed frameworks that are considered > during allocation. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 0498cd5e54b0e4b87a767585a77699653aa52179 > > Diff: https://reviews.apache.org/r/49616/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jacob Janco > >
