----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42685/#review141534 -----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On Jan. 27, 2016, 5:26 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42685/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2016, 5:26 a.m.) > > > Review request for mesos, Benjamin Bannier and Vinod Kone. > > > Bugs: MESOS-4364 > https://issues.apache.org/jira/browse/MESOS-4364 > > > Repository: mesos > > > Description > ------- > > Validated either role or roles in FrameworkInfo can be set, > but never both. > > > Diffs > ----- > > src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 > src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 > > Diff: https://reviews.apache.org/r/42685/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Qian Zhang > >
