> On July 8, 2016, 5:23 p.m., Vinod Kone wrote: > > src/tests/master_slave_reconciliation_tests.cpp, line 620 > > <https://reviews.apache.org/r/49692/diff/1/?file=1437562#file1437562line620> > > > > not yours. > > > > @joerg: can you remind me why you do AWAIT_READY(status) here instead > > of up at #602? also why do you need AWAIT_READY(_statusUpdate)?
https://reviews.apache.org/r/49892/ - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49692/#review141301 ----------------------------------------------------------- On July 6, 2016, 8:38 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49692/ > ----------------------------------------------------------- > > (Updated July 6, 2016, 8:38 a.m.) > > > Review request for mesos, Joerg Schad and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Removed an unnecessary `Clock::settle` from a test case. > > > Diffs > ----- > > src/tests/master_slave_reconciliation_tests.cpp > 87cff8cbce0af5cfaf369854b812599d36c762d9 > > Diff: https://reviews.apache.org/r/49692/diff/ > > > Testing > ------- > > `./src/mesos-tests > --gtest_filter="MasterSlaveReconciliationTest.SlaveReregisterActiveFrameworks" > --gtest_repeat=700 --gtest_break_on_failure` > > > Thanks, > > Neil Conway > >
