> On July 11, 2016, 4:15 p.m., Qian Zhang wrote:
> > Is this (">>") the coding convention of Mesos? If so, we may need to 
> > mention it in 
> > https://github.com/apache/mesos/blob/master/docs/c%2B%2B-style-guide.md. 
> > And I see there are still a lot of code in Mesos using "> >" now, maybe we 
> > need a separate patch to update all of them?

The `> >` form is the exception to how C++ is used nowadays; that form works 
around a deficiency where these right angle brackets might have been understood 
as some form of `operator>>`. In C++11 which is used in Mesos we do not need 
this workaround. We usually fix these as we touch code, but I filed MESOS-5830 
for the sweep.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49840/#review141689
-----------------------------------------------------------


On July 9, 2016, 1:57 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49840/
> -----------------------------------------------------------
> 
> (Updated July 9, 2016, 1:57 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed the right angle brackets in routing tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/routing_tests.cpp 
> 452a56da84f7508709d6e71f121bcf6219f992e6 
> 
> Diff: https://reviews.apache.org/r/49840/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to