> On July 11, 2016, 3:42 p.m., Avinash sridharan wrote: > > src/tests/containerizer/routing_tests.cpp, line 258 > > <https://reviews.apache.org/r/49841/diff/1/?file=1440234#file1440234line258> > > > > Instead of failing over here should we be disabling these tests if the > > libnl version is not correct? > > > > That's the convention we have using with the other tests > > (cgroups/netcls). Does it make sense to add a filter for these tests?
Yeah, we should follow up with a patch. This patch just do the splitting. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49841/#review141706 ----------------------------------------------------------- On July 8, 2016, 11:57 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49841/ > ----------------------------------------------------------- > > (Updated July 8, 2016, 11:57 p.m.) > > > Review request for mesos, Avinash sridharan and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Advanced tests need some higher version of libnl. > > > Diffs > ----- > > src/tests/containerizer/routing_tests.cpp > 452a56da84f7508709d6e71f121bcf6219f992e6 > > Diff: https://reviews.apache.org/r/49841/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
