----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49903/#review141750 -----------------------------------------------------------
Ship it! Ship It! - Isabel Jimenez On July 11, 2016, 4:31 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49903/ > ----------------------------------------------------------- > > (Updated July 11, 2016, 4:31 p.m.) > > > Review request for mesos, Isabel Jimenez, Michael Park, and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Prior to this patch, empty `Resources` instances have been omitted > if printed to a stream. This showed up as double space, which is > confusing. Now, an empty `Resources` instance is explicitly printed. > > Prior: > <...> with oversubscribed resources (total: <...>, allocated: ) > > After: > <...> with oversubscribed resources {} (total: <...>, allocated: {}) > > > Diffs > ----- > > src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 > src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a > > Diff: https://reviews.apache.org/r/49903/diff/ > > > Testing > ------- > > make check + visual inspection > > Prior: > ``` > Agent 0aa85f40-9409-45d7-b45c-6b6905b2836d-S0 (192.168.0.18) updated with > oversubscribed resources (total: cpus(*):8; mem(*):15360; disk(*):470847; > ports(*):[31000-32000], allocated: ) > ``` > > After: > ``` > Agent cd200600-03f7-4f5a-8721-94659c149145-S0 (192.168.0.18) updated with > oversubscribed resources {} (total: cpus(*):8; mem(*):15360; disk(*):470847; > ports(*):[31000-32000], allocated: {}) > ``` > > > Thanks, > > Alexander Rukletsov > >
