> On July 11, 2016, 11:37 p.m., Joseph Wu wrote: > > Content-wise, looks good. > > > > I've left some comments below on a few stylistic nits, which I'll fix > > before committing. > > I also went ahead and tweaked your patch description to explain what the > > improvement was.
Hi, Joseph, thank you so much for helping fix these issues! - Yanyan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/#review141789 ----------------------------------------------------------- On July 11, 2016, 7:52 a.m., Yanyan Hu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48593/ > ----------------------------------------------------------- > > (Updated July 11, 2016, 7:52 a.m.) > > > Review request for mesos, Alexander Rukletsov, Guangya Liu, and Joris Van > Remoortere. > > > Bugs: MESOS-5425 > https://issues.apache.org/jira/browse/MESOS-5425 > > > Repository: mesos > > > Description > ------- > > This patch reimplement Ranges subtraction using > IntervalSet data type: Ranges values will be > converted to IntervalSet values for subtraction > and the result will be converted back to Ranges > after subtraction is done. This change is for > fixing jira MESOS-5425. > > > Diffs > ----- > > src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b > src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 > > Diff: https://reviews.apache.org/r/48593/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yanyan Hu > >
