> On July 12, 2016, 4:16 a.m., Alex Clemmer wrote: > > src/tests/CMakeLists.txt, line 71 > > <https://reviews.apache.org/r/49688/diff/5/?file=1441338#file1441338line71> > > > > Can we please use the Mesos style TODO format? Specifically: > > > > * add semicolons after the `TODO(xxx):` > > * capitalize the first letter of the message > > * end message with a period > > * indent to line up with the rest of the block (i.e., put 2 spaces > > between the start of the line and the `#` character) > > > > In this case, it should look something like: > > > > ``` > > TODO(srbrahma): Needs leveldb to compile. > > ``` > > > > Also would be good to have a bug # that corresponds to the issue. > > Alex Clemmer wrote: > Actually, it looks like all of these `TODO`s are not quite correct -- we > do support leveldb build, and we don't need anything else except to build the > qos controller that I mentioned earlier. These can all be safely uncommented > as soon as you add that to the build. > > Please do keep in mind the comment about the `TODO` formatting, though. > > Alex Clemmer wrote: > That said, I do believe you will have to add `state/leveldb.cpp` to the > build before that works.
(Also, don't forget that `ldcache_tests.cpp` is Linux-specific.) - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/#review141822 ----------------------------------------------------------- On July 11, 2016, 3:46 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49688/ > ----------------------------------------------------------- > > (Updated July 11, 2016, 3:46 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > Added cmake build for mesos tests. > > > Diffs > ----- > > cmake/MesosConfigure.cmake b2318ed8eb4e11de43abfc15f51d12b2c0ff8fa1 > src/tests/CMakeLists.txt 3c530631d22aa1cfdc2c600112059601bba7d6b7 > src/tests/cmake/TestsConfigure.cmake PRE-CREATION > > Diff: https://reviews.apache.org/r/49688/diff/ > > > Testing > ------- > > cmake .. > cmake check > > > Thanks, > > Srinivas Brahmaroutu > >
