----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49870/#review142155 -----------------------------------------------------------
src/examples/CMakeLists.txt (line 113) <https://reviews.apache.org/r/49870/#comment207682> Quick fly-by comment: All your cmake function calls in this patch have an extra space. i.e. `set (` instead of `set(` everywhere else. - Joseph Wu On July 12, 2016, 5:38 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49870/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 5:38 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > Added test executables required to run tests. > > > Diffs > ----- > > src/examples/CMakeLists.txt PRE-CREATION > src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION > > Diff: https://reviews.apache.org/r/49870/diff/ > > > Testing > ------- > > cmake .. && make > > > Thanks, > > Srinivas Brahmaroutu > >