> On July 10, 2016, 9:50 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp, lines 36-37 > > <https://reviews.apache.org/r/49813/diff/2/?file=1440351#file1440351line36> > > > > Why do you do the forward declaration rather than include cgroups.hpp? > > haosdent huang wrote: > Because we include > `slave/containerizer/mesos/isolators/cgroups/subsystem.hpp` in > `src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp`. If we include > `src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp` in > `slave/containerizer/mesos/isolators/cgroups/subsystem.hpp`, it would bring > circular dependencies. So I forward declaration here.
Because we use callback now, we don't need include `cgroups.hpp` in `subsystem.hpp` which bring circular dependencies. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49813/#review141605 ----------------------------------------------------------- On July 14, 2016, 4:43 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49813/ > ----------------------------------------------------------- > > (Updated July 14, 2016, 4:43 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Repository: mesos > > > Description > ------- > > Added stubs for the unified cgroups isolator. > > > Diffs > ----- > > src/CMakeLists.txt 9d8a8ba674f0bf2d081acf0447dc2de28cfcf010 > src/Makefile.am 1d798d6c02b97c15e15d8216158676b91cbccaff > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/49813/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
