----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49938/ -----------------------------------------------------------
(Updated July 14, 2016, 1:31 p.m.) Review request for mesos, Benjamin Mahler and Vinod Kone. Summary (updated) ----------------- Updated GET_METRICS call in v1 api to return metrics grouped by types. Bugs: MESOS-5731 https://issues.apache.org/jira/browse/MESOS-5731 Repository: mesos Description (updated) ------- Updated GET_METRICS call in v1 api to return metrics grouped by types. Diffs (updated) ----- include/mesos/master/master.proto 7fb7153b5498a55469d2c72873c45fb534c0e60d include/mesos/v1/master/master.proto c9e4359fff018de55d83da5cde0eb6d59dacfc3e src/master/http.cpp 42ba3643daf8f6fe63152178214b57e3b773d93e src/tests/api_tests.cpp 55e825ea6a3bd43c76dc67e8b90a97e8c9530a47 Diff: https://reviews.apache.org/r/49938/diff/ Testing ------- Modified MasterAPITest.GetMetrics to make sure we return metrics grouped by types. 1. Run master: ./bin/mesos-master.sh --ip=127.0.0.1 --work_dir=/var/lib/mesos 2. Call GET_METRICS: curl --header "Content-Type:application/json" --data '{"type": "GET_METRICS", "get_metrics":{}}' http://localhost:5050/api/v1 | python -m json.tool Thanks, Tuan-Anh Hoang-Vu