> On July 15, 2016, 7:49 a.m., Klaus Ma wrote: > > src/master/allocator/sorter/drf/sorter.hpp, line 22 > > <https://reviews.apache.org/r/50044/diff/1/?file=1444158#file1444158line22> > > > > This's not necessary, `sorter/sorter.hpp` had included it. > > Guangya Liu wrote: > I think the reason here is we generally don't rely on transitive includes > as it's harder to maintain.
We should keep small list of header; if anyone missed removing, it'll impact compile performance. - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50044/#review142308 ----------------------------------------------------------- On July 15, 2016, 3:35 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50044/ > ----------------------------------------------------------- > > (Updated July 15, 2016, 3:35 a.m.) > > > Review request for mesos, Guangya Liu, Klaus Ma, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > We now prefer to use vector rather than list in general for > efficiency reasons, unless we need to take advantage of the > operations that are efficient on a linked-list. > > > Diffs > ----- > > src/master/allocator/sorter/drf/sorter.hpp > e29feebd70277c79f7c3f6fb233e7a36501cf220 > src/master/allocator/sorter/drf/sorter.cpp > 7df4dd641b21ea0705368861bf4679fed1ef078d > src/master/allocator/sorter/sorter.hpp > f5f0b086cb95eb2ab70b3f67e5b20814925bf702 > src/tests/sorter_tests.cpp bdd4355bfcd7b1fa1c22983f8e0ee6f20906917a > > Diff: https://reviews.apache.org/r/50044/diff/ > > > Testing > ------- > > make check > > benchmarks: with 1000 clients, sort time is reduced by 72 us > > > Thanks, > > Benjamin Mahler > >
