> On July 15, 2016, 4:26 p.m., Greg Mann wrote: > > Neil I agree - not useful logging information :-) Shall we just remove it > > instead?
+1 to killing the log message. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49602/#review142391 ----------------------------------------------------------- On July 4, 2016, 6:05 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49602/ > ----------------------------------------------------------- > > (Updated July 4, 2016, 6:05 p.m.) > > > Review request for mesos, Anand Mazumdar and Greg Mann. > > > Repository: mesos > > > Description > ------- > > Fixed log message to avoid spanning multiple lines. > > > Diffs > ----- > > src/common/resources.cpp f6ff92b591c15bc8e93fd85e1896349c3a7bb968 > src/v1/resources.cpp 8c3f2d1c1529915a59d47fe37bb3fc7a3267079a > > Diff: https://reviews.apache.org/r/49602/diff/ > > > Testing > ------- > > Previous output: > > ``` > I0704 19:52:23.530931 1970868224 resources.cpp:572] Parsing resources as JSON > failed: cpus:4;mem:512;disk:0 > Trying semicolon-delimited string format instead > I0704 19:52:23.530920 528384 process.cpp:2676] Resuming > (1)@192.168.0.104:61317 at 2016-07-04 17:52:23.530142976+00:00 > ``` > > New output: > > ``` > I0704 19:58:00.678043 1970868224 resources.cpp:572] Parsing resources as JSON > failed: 'cpus:4;mem:512;disk:0'; trying semicolon-delimited string format > instead > I0704 19:58:00.678032 2138112 process.cpp:2676] Resuming > (1)@192.168.0.104:61374 at 2016-07-04 17:58:00.675815168+00:00 > ``` > > Note that I'm not convinced this is a super useful thing to be logging, even > at `VLOG(1)`, so I'd also be fine with just removing the log statement > altogether. > > > Thanks, > > Neil Conway > >
