----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49814/#review142508 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp (lines 83 - 85) <https://reviews.apache.org/r/49814/#comment208059> I would suggest to make the naming of these 3 parameters consistent, i.e., all starting with underscore. You can take the method below it as an example :-) src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 108 - 110) <https://reviews.apache.org/r/49814/#comment208057> Ditto src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 113) <https://reviews.apache.org/r/49814/#comment208060> s/used/use/ src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 114) <https://reviews.apache.org/r/49814/#comment208058> s/by/be/ - Qian Zhang On July 15, 2016, 11:31 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49814/ > ----------------------------------------------------------- > > (Updated July 15, 2016, 11:31 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5041 > https://issues.apache.org/jira/browse/MESOS-5041 > > > Repository: mesos > > > Description > ------- > > Implemented `CgroupsIsolatorProcess::create`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > c57baec88437f68886702a40ec8a6a6458546119 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 4a9f55bf3b217405bf90943f27a976422877a99e > > Diff: https://reviews.apache.org/r/49814/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
