----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50186/ -----------------------------------------------------------
(Updated July 19, 2016, 9:55 a.m.) Review request for mesos and Alexander Rukletsov. Repository: mesos Description ------- Depending on timing, the master might rescind an offer, which causes a GMock warning. It is better to wait for the offer and then wait for it to be rescinded. Diffs ----- src/tests/reservation_tests.cpp 26bd762db657d5c83cf4b7575ecbbbc26e95d917 Diff: https://reviews.apache.org/r/50186/diff/ Testing (updated) ------- `./src/mesos-tests --gtest_filter="ReservationTest.CompatibleCheckpointedResourcesWithPersistentVolumes" --verbose --gtest_repeat=400` Without the patch, emits a GMock warning on ~1% of runs. With the patch, does not emit the warning. Note that the warning seems to occur more often if you remove the `os::sleep` from `Clock::settle`, which we want to do anyway. Thanks, Neil Conway
