----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/#review143335 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (lines 87 - 88) <https://reviews.apache.org/r/49828/#comment209123> I would suggest to merge these two line into a single line `return ResourceStatistics();`. src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (lines 94 - 95) <https://reviews.apache.org/r/49828/#comment209124> Ditto. - Qian Zhang On July 22, 2016, 3:07 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49828/ > ----------------------------------------------------------- > > (Updated July 22, 2016, 3:07 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5039 > https://issues.apache.org/jira/browse/MESOS-5039 > > > Repository: mesos > > > Description > ------- > > Added default methods implementations for `Subsystem` base class. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp > a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 > > Diff: https://reviews.apache.org/r/49828/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
