----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50181/#review143352 -----------------------------------------------------------
Patch looks great! Reviews applied: [50181] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On July 25, 2016, 6:17 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50181/ > ----------------------------------------------------------- > > (Updated July 25, 2016, 6:17 a.m.) > > > Review request for mesos, Anand Mazumdar, Jay Guo, and Vinod Kone. > > > Bugs: MESOS-5860 > https://issues.apache.org/jira/browse/MESOS-5860 > > > Repository: mesos > > > Description > ------- > > This changes to wait for every `StatusUpdateAcknowledgementMessage` > exactly in this test case to make sure they don't conflict each other. > > > Diffs > ----- > > src/tests/api_tests.cpp 88523fdb3469c40b7ff71d5d753b645d20bc51bd > > Diff: https://reviews.apache.org/r/50181/diff/ > > > Testing > ------- > > Before apply the patch, could reproduce by > > ``` > $ stress --cpu 4 --timeout 3600s & > $ GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*MasterAPITest.GetTasks*" > --gtest_break_on_failure --gtest_repeat=-1 --verbose > ``` > > After apply the patch, could not reproduce by > > ``` > $ stress --cpu 4 --timeout 3600s & > $ GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*MasterAPITest.GetTasks*" > --gtest_break_on_failure --gtest_repeat=-1 --verbose > ``` > > So verified this patch resolve the flaky. > > > Thanks, > > haosdent huang > >
