> On July 22, 2016, 9:09 a.m., Adam B wrote: > > 3rdparty/libprocess/include/process/help.hpp, line 82 > > <https://reviews.apache.org/r/50329/diff/1/?file=1450984#file1450984line82> > > > > Let's make this Realm, and then we can include "mesos-master-scheduler" > > for `/v1/scheduler`
Ah yep, we do need to account for the scheduler realm. However, I don't like the idea of leaking Mesos-level realms into libprocess. If we have helper functions for HTTP endpoint help strings that include Mesos-level concepts, then they should probably be moved into Mesos somewhere. 'src/common/http.cpp' might be a suitable location? - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50329/#review143207 ----------------------------------------------------------- On July 22, 2016, 7:50 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50329/ > ----------------------------------------------------------- > > (Updated July 22, 2016, 7:50 a.m.) > > > Review request for mesos, Adam B and Zhitao Li. > > > Bugs: MESOS-5851 > https://issues.apache.org/jira/browse/MESOS-5851 > > > Repository: mesos > > > Description > ------- > > This patch updates the endpoint help `AUTHENTICATION()` > helper to include information about read-only and read-write > endpoints. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/help.hpp > 3393b71c484bb8c55c6a4cd2a27dcb798e841a80 > 3rdparty/libprocess/src/logging.cpp > cf7b43d2339df57ce899677419968d7e00ad8c38 > 3rdparty/libprocess/src/metrics/metrics.cpp > ac1544e70f5884f946ce3c31c5430c6a2c1f9dd1 > 3rdparty/libprocess/src/profiler.cpp > 0c4949e6aa5a3e94b84d43d0e23ba8a8817fdf4d > > Diff: https://reviews.apache.org/r/50329/diff/ > > > Testing > ------- > > Regenerated endpoint documentation in a subsequent patch. > > > Thanks, > > Greg Mann > >
