----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50217/#review143447 -----------------------------------------------------------
Fix it, then Ship it! Reviewbot failed because the test script wasn't added to the `distcheck` build. I'll go ahead and add that for you. Also, I'm going to modify your commit description before committing :) ``` diff --git a/src/Makefile.am b/src/Makefile.am index e8c63e9..7fd49ac 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -2247,6 +2247,7 @@ EXTRA_DIST += \ dist_check_SCRIPTS += \ tests/balloon_framework_test.sh \ + tests/disk_full_framework_test.sh \ tests/dynamic_reservation_framework_test.sh \ tests/test_http_framework_test.sh \ tests/java_exception_test.sh \ ``` src/tests/disk_full_framework_test.sh (line 66) <https://reviews.apache.org/r/50217/#comment209243> This is deprecated in favor of `disk/du`. I'll make the change before committing. - Joseph Wu On July 25, 2016, 12:22 p.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50217/ > ----------------------------------------------------------- > > (Updated July 25, 2016, 12:22 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5855 > https://issues.apache.org/jira/browse/MESOS-5855 > > > Repository: mesos > > > Description > ------- > > Added disk full framework to example frameworks unit test. > > > Diffs > ----- > > src/tests/disk_full_framework_test.sh PRE-CREATION > src/tests/examples_tests.cpp ac513ce9aa3c8f366fe81ba937e3dc0d51a26940 > > Diff: https://reviews.apache.org/r/50217/diff/ > > > Testing > ------- > > > Thanks, > > Artem Harutyunyan > >