----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41787/#review143643 -----------------------------------------------------------
src/tests/slave_recovery_tests.cpp (lines 419 - 428) <https://reviews.apache.org/r/41787/#comment209476> I would prefer to place `Clock::pause()` at the very beginning of the test, with `Clock::resume()` placed at the very end of the test. I think this is a little easier for future authors to reason about - we can keep the clock paused for the entire test, rather than pausing it for only a portion. And the same for the other occurrences below. What do you think? - Greg Mann On April 11, 2016, 1:33 a.m., Jian Qiu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41787/ > ----------------------------------------------------------- > > (Updated April 11, 2016, 1:33 a.m.) > > > Review request for mesos, Alexander Rukletsov and Timothy Chen. > > > Bugs: MESOS-4158 > https://issues.apache.org/jira/browse/MESOS-4158 > > > Repository: mesos > > > Description > ------- > > Some tests are sped up by using clock, > while some relies on the fix of MESOS-4111 and a comment is put. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8 > > Diff: https://reviews.apache.org/r/41787/diff/ > > > Testing > ------- > > SlaveRecoveryTest/0.RecoverStatusUpdateManager (335 ms total) > SlaveRecoveryTest/0.ReconnectExecutor (333 ms total) > SlaveRecoveryTest/0.ReconcileKillTask (443 ms total) > SlaveRecoveryTest/0.ReconcileShutdownFramework (1379 ms total) > SlaveRecoveryTest/0.CleanupExecutor (474 ms total) > > > Thanks, > > Jian Qiu > >