> On July 27, 2016, 11:35 p.m., Greg Mann wrote: > > I'm seeing the following test failure after applying this patch chain: > > > > ``` > > [ RUN ] MesosSchedulerDriverTest.MetricsEndpoint > > ../../src/tests/scheduler_driver_tests.cpp:103: Failure > > Value of: (response).get().status > > Actual: "503 Service Unavailable" > > Expected: OK().status > > Which is: "200 OK" > > ../../src/tests/scheduler_driver_tests.cpp:104: Failure > > Value of: (response).get().headers["Content-Type"] > > Actual: "text/plain; charset=utf-8" > > Expected: APPLICATION_JSON > > Which is: "application/json" > > ../../src/tests/scheduler_driver_tests.cpp:108: Failure > > parse: syntax error at line 1 near: Endpoint '/metrics//snapshot' is not an > > authorizable endpoint. > > [ FAILED ] MesosSchedulerDriverTest.MetricsEndpoint (102 ms) > > ``` > > Joseph Wu wrote: > This is a rather silly rebasing artifact. (e.g. I should have run the > tests after rebasing :) > > See how the `process::http::get` call in this diff uses `/snapshot`: > https://reviews.apache.org/r/40411/diff/2/ > > Whereas, in the last half year or so, the leading `/` was removed: > https://reviews.apache.org/r/40411/diff/3/
:D - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40512/#review143850 ----------------------------------------------------------- On July 26, 2016, 9:17 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40512/ > ----------------------------------------------------------- > > (Updated July 26, 2016, 9:17 p.m.) > > > Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. > > > Bugs: MESOS-3820 > https://issues.apache.org/jira/browse/MESOS-3820 > > > Repository: mesos > > > Description > ------- > > This builds upon earlier changes to complete `process::finalize`. > Tests which need to reconfigure libprocess, such as some SSL-related > tests, can use `process::reinitialize` to do so. > > This method may also be useful for providing additional isolation > between tests, such as cleaning up all processes after each test case. > > > Diffs > ----- > > 3rdparty/libprocess/src/openssl.cpp > a73313b3221d6c80b35f21c00f35d9f9c795f1ec > 3rdparty/libprocess/src/process.cpp > 7f331b812de2f0437838f48e0959441c8e04c358 > > Diff: https://reviews.apache.org/r/40512/diff/ > > > Testing > ------- > > TODO: Define `process::reinitialize` in several tests, such as `HTTPTest`, > `MetricsTest`, and `ReapTest` and call `process::reinitialize` before and > after tests. > > > Thanks, > > Joseph Wu > >
