----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50627/#review144455 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 220) <https://reviews.apache.org/r/50627/#comment210469> s/prepares/futures/ src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 222) <https://reviews.apache.org/r/50627/#comment210468> s/msgs/messages/ src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 230) <https://reviews.apache.org/r/50627/#comment210470> "Failed to prepare subsystems: " + ... src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 272 - 286) <https://reviews.apache.org/r/50627/#comment210471> Let's be consisent and use `_isolator` rather than a lambda here. src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 315 - 329) <https://reviews.apache.org/r/50627/#comment210472> Ditto. - Jie Yu On July 31, 2016, 5:47 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50627/ > ----------------------------------------------------------- > > (Updated July 31, 2016, 5:47 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5041 > https://issues.apache.org/jira/browse/MESOS-5041 > > > Repository: mesos > > > Description > ------- > > In order to get the error message for each subsystem, this patch > changes to use `await` on `Subsystem` operations and combines every > unready `Future` error message. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > 422b4653fc3cb3d14c94b93ff456625fc59fbb27 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > bd20631a9650cf84e99c6489b2e92bc40ed764ca > > Diff: https://reviews.apache.org/r/50627/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
