> On July 29, 2016, 12:45 p.m., Alexander Rukletsov wrote: > > src/slave/containerizer/mesos/containerizer.hpp, line 304 > > <https://reviews.apache.org/r/50515/diff/1/?file=1455390#file1455390line304> > > > > See my comment in the previous patch regarding `sequence`.
Fixed, renamed it to `mesos-container-status-updates `. - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50515/#review144087 ----------------------------------------------------------- On Aug. 2, 2016, 1:47 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50515/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2016, 1:47 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-5917 > https://issues.apache.org/jira/browse/MESOS-5917 > > > Repository: mesos > > > Description > ------- > > After this change, all actors should have a distinguishable ID, making > it possible to match the logging output or the output of the > "__process__" enpoint to the source actor. > > > Diffs > ----- > > src/examples/test_hook_module.cpp f4063d398838d99d8c055447cd411124cfb9985f > src/exec/exec.cpp 90a16a904100eeee27969adf93091bcce253a98d > src/linux/cgroups.cpp 610857a436e07e0f2f4629d3a389e90fa31cc258 > src/linux/perf.cpp ea823b32edaa82a71cbfac9932aae543c0d7bef4 > src/linux/routing/link/link.cpp 96bd50e245ef7e29d4767ba0871e0ac4abad55a0 > src/slave/container_loggers/logrotate.cpp > b863d931b08992ea9e94a7e6837b44cfc94ae8f1 > src/slave/container_loggers/sandbox.cpp > 00272f82de9a6257d8654b36085b3427c18e81ec > src/slave/containerizer/composing.cpp > 15d059f0bbda4e8cb93c65c09327dde1e34d3e7b > src/slave/containerizer/mesos/containerizer.hpp > 3274e09f66b53cb67b6a20c88faa4c1e45569b22 > src/slave/containerizer/mesos/isolators/appc/runtime.cpp > e8fe131e355796d450dd4d823a6be4e4e4ec4506 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > c304e2a896d1d8ae085914c0fd7e6326fd68ad2d > src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp > dddd4f0a43b9d8b0d04a8e3e11b1a11688d4fa93 > src/slave/containerizer/mesos/isolators/cgroups/devices.cpp > 66db4fc7253094a2691ead3a5621f186b59c1f21 > src/slave/containerizer/mesos/isolators/cgroups/mem.cpp > af8d1654a47b3ce50878c69b6f9aad053d3055e6 > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > 2665b022260b9228d4d34f030feb0d2f5de54bb3 > src/slave/containerizer/mesos/isolators/cgroups/perf_event.hpp > 1de38491a33e5782b20e5ee491412779d09ee391 > src/slave/containerizer/mesos/isolators/docker/runtime.cpp > 5af0ae93526af41ec54263fd44b5c2b55a7011a4 > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > d10c424b48cb2ff974c49f91dd75805859ec39ef > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > ed7366aeeed6646b74f2087fd00449c70dd16e82 > src/slave/containerizer/mesos/isolators/filesystem/posix.cpp > 0809e8ec35232fbdafee171a7a960cbdec272134 > src/slave/containerizer/mesos/isolators/filesystem/shared.cpp > 51d15186bd5005e2e069d68907a9e3969eb65ebb > src/slave/containerizer/mesos/isolators/filesystem/windows.cpp > 0bee68bea363d53978d82db2f85ee16744580bc9 > src/slave/containerizer/mesos/isolators/gpu/isolator.cpp > c7e8cf0ec3ff10e9d5ddd218b0e33ed1e8195b68 > src/slave/containerizer/mesos/isolators/namespaces/pid.hpp > 4e0dcd11067e0b05338f7c61e11840b7004ecbc9 > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp > 527c579bb80bb0a02ca4ff16d1b1d94823d0dea0 > src/slave/containerizer/mesos/isolators/network/port_mapping.hpp > 21a86e3087bea46a2d2125e53292251243086554 > src/slave/containerizer/mesos/isolators/posix.hpp > e5cee9c6a77ade1a48b056c981ad23edee56969d > src/slave/containerizer/mesos/isolators/posix/disk.cpp > 3dfe7ad4477dd1a6c8585bf761eaf435fd0cb366 > src/slave/containerizer/mesos/isolators/windows.hpp > aec331663a58b17fac0396e2d17df7a28e1ee164 > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > 19e55111edc0bf80a14fb7b2dade120b4432de53 > src/slave/containerizer/mesos/provisioner/appc/store.cpp > c27b1b5ca05a5883831c86575ac129903e758598 > src/slave/containerizer/mesos/provisioner/backends/aufs.cpp > 54c005764c4aa84af2606b69e5f5f10db61fab80 > src/slave/containerizer/mesos/provisioner/backends/bind.cpp > af9544e2eaef754a7cf4cbb865c1e0a054f01d7f > src/slave/containerizer/mesos/provisioner/backends/copy.cpp > b9f6d7a5d5ee341d7e3ac2663a8d2a5fc4746096 > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp > e3d8494694447c57596f332c9f120549478a5c7d > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > 4be26faf0d46ee29fb4169bfe69264c57a6b9fce > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 6545a6d29cb91d6cf8919c7796c283084178e499 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 81e9d94553874a74cc115d9a1fd659652313a94c > src/slave/containerizer/mesos/provisioner/provisioner.cpp > 40ee1da5ea453127c1e5e4cdf4b9a49bc998698a > src/slave/gc.hpp 294b75f43b2f5b589e5fc93fd544b6f38e031e6b > src/slave/qos_controllers/load.cpp abc98fa77dae8bc7b49b28d397eed80ff10d2a2b > src/slave/qos_controllers/noop.cpp 38b73bc8f5c4ce427b0d00a021a306bf787b0acc > src/slave/resource_estimators/fixed.cpp > 767ba6acfe6c91ed44c684d9c929057876099b79 > src/slave/resource_estimators/noop.cpp > ffc9a3ed7aaba48c60ba12afdc5e7a2dc7098b8d > src/state/in_memory.cpp c16637d4b216424a40c4c49ce38c714144350d91 > src/state/leveldb.cpp 7f8a1d2bc4c970459c82481ce50d407efe4ae89f > src/state/log.cpp 1513c2a549a2c1935830ced3532efd5e255a68a9 > src/state/zookeeper.cpp 9b37204e462d77866de1df068ea6eb750ad708a4 > src/uri/fetchers/docker.cpp 211be6fdf416621c467faa5592c9e52a49b450ca > > Diff: https://reviews.apache.org/r/50515/diff/ > > > Testing > ------- > > `make check` in OS X and various linux distribution. > > I also looked at the output of the `__process__` endpoint. After this change, > most of the unidentifiable processes have a nicer ID. The goal of this review > chain is to give all processes there an identifiable ID. > > > Thanks, > > Gastón Kleiman > >
