----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50664/#review144530 -----------------------------------------------------------
Ship it! Ship It! - Joris Van Remoortere On Aug. 1, 2016, 6:16 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50664/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2016, 6:16 p.m.) > > > Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > Previously the module's inner loop followed via `.then([=]` > which potentially executes the continuation on a different process. > This patch fixes this behavior (it should run on the same process) > and future-proofs this code in case the module is extended with > additional processes/behavior. > > > Diffs > ----- > > src/slave/container_loggers/logrotate.cpp > b863d931b08992ea9e94a7e6837b44cfc94ae8f1 > > Diff: https://reviews.apache.org/r/50664/diff/ > > > Testing > ------- > > make check (OSX) > > > Thanks, > > Joseph Wu > >
