-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50581/
-----------------------------------------------------------

(Updated Aug. 2, 2016, 3:43 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Repository: mesos


Description
-------

Added logs for pre-exec commands to sandbox in MesosContainerizerLaunch.


Diffs (updated)
-----

  src/slave/containerizer/mesos/launch.cpp 
e1cf9d5226ca4b4b33d8f9d9efb968be35d4ec4d 

Diff: https://reviews.apache.org/r/50581/diff/


Testing
-------

make check

sudo ./bin/mesos-tests.sh

The sandbox log will look as the following:
```
Executing pre-exec command 
{"arguments":["mesos-containerizer","mount","--help=false","--operation=make-rslave","--path=\/"],"shell":false,"value":"\/home\/vagrant\/mesos\/build\/src\/mesos-containerizer"}
Executing pre-exec command 
{"arguments":["mount","-n","--rbind","\/tmp\/LinuxFilesystemIsolatorTest_ROOT_ChangeRootFilesystemCommandExecutor_NuNoW5\/slaves\/c203dac1-ca1c-4a38-8d6b-3c48af6a5ab9-S0\/frameworks\/c203dac1-ca1c-4a38-8d6b-3c48af6a5ab9-0000\/executors\/09e642aa-e545-44e9-8bca-18292b171cca\/runs\/7f494191-2518-4f37-836a-bcdee4b634f2","\/tmp\/LinuxFilesystemIsolatorTest_ROOT_ChangeRootFilesystemCommandExecutor_NuNoW5\/provisioner\/containers\/7f494191-2518-4f37-836a-bcdee4b634f2\/backends\/copy\/rootfses\/43665fdd-2361-4a82-9f92-56ff21b428c9\/mnt\/mesos\/sandbox"],"shell":false,"value":"mount"}
I0802 20:34:17.818397 29502 exec.cpp:161] Version: 1.1.0
I0802 20:34:17.826095 29561 exec.cpp:236] Executor registered on agent 
c203dac1-ca1c-4a38-8d6b-3c48af6a5ab9-S0
Received SUBSCRIBED event
Subscribed executor on vagrant-ubuntu-trusty-64
Received LAUNCH event
Starting task 09e642aa-e545-44e9-8bca-18292b171cca
/home/vagrant/mesos/build/src/mesos-containerizer launch 
--command="{"shell":true,"value":"test -d \/mnt\/mesos\/sandbox"}" 
--help="false" 
--rootfs="/tmp/LinuxFilesystemIsolatorTest_ROOT_ChangeRootFilesystemCommandExecutor_NuNoW5/provisioner/containers/7f494191-2518-4f37-836a-bcdee4b634f2/backends/copy/rootfses/43665fdd-2361-4a82-9f92-56ff21b428c9"
 --unshare_namespace_mnt="false" --user="root" 
--working_directory="/mnt/mesos/sandbox"
```


Thanks,

Gilbert Song

Reply via email to