> On Aug. 9, 2016, 9:26 p.m., Jie Yu wrote: > > > > Kevin Klues wrote: > Look back at the thread above started by Vinod. This was dicussed in > there, though it's not clear what the outcome was. > > Kevin Klues wrote: > Also, if you look further down in the patch, the line: > > ``` > ln -s $(DESTDIR)/$(includedir)/mesos/agent \ > $(DESTDIR)/$(includedir)/mesos/slave > ``` > > Should have accommodated for this.
Thought this should probably be a relative symlink rather than an absolute one, i.e., ``` ln -s agent $(DESTDIR)/$(includedir)/mesos/slave ``` - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46676/#review145265 ----------------------------------------------------------- On April 27, 2016, 1:57 a.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46676/ > ----------------------------------------------------------- > > (Updated April 27, 2016, 1:57 a.m.) > > > Review request for mesos, Kevin Klues and Vinod Kone. > > > Bugs: mesos-5230 > https://issues.apache.org/jira/browse/mesos-5230 > > > Repository: mesos > > > Description > ------- > > This patch did the following changes: > > 1. Change the 'make install' headers installation location from > '$(DESTDIR)/include/mesos/slave' to '$(DESTDIR)include/mesos/agent' > > 2. As we do not change the folder name from 'include/mesos/slave' > to 'include/mesos/agent', create a 'slave -> agent' symlink in dir > '$(DESTDIR)/include/mesos' > > > Diffs > ----- > > CHANGELOG 57f5457640c9b7ca2cb7707f2962dd0421f090f7 > src/Makefile.am e024c6d65608a55765e527a8668c415723dcfcca > > Diff: https://reviews.apache.org/r/46676/diff/ > > > Testing > ------- > > cd mesos > ./bootstrap > mkdir build > cd build > ../configure --prefix=${HOME}/install/mesos > make > make check > make install > > > Thanks, > > zhou xing > >