> On Aug. 10, 2016, 7:02 p.m., Kevin Klues wrote: > > support/mesos-style.py, lines 228-234 > > <https://reviews.apache.org/r/50910/diff/1/?file=1467414#file1467414line228> > > > > I know we didn't talk about this, but I realized recently that we > > actually *have* to run pylint inside the virtual environment, otherwise it > > runs using the system python, which is not what we want..... Especially for > > import libraries.
There are two approaches to this: 1) We can either activate the virtualenv from the CLI and than run pylint. But that means if the virtualenv is not created within the CLI we will have to create it and activate it. 2) We can integrate the virtualenv to the project wide bootstrap and thus ensuring the the virtualenv is created for the project on bootstrapping mesos. This seems to be the better way to do it however might require significant changes as opposed to (1). It'd be desirable to have a project-wide virtualenv at some point however even if we choose to not do so right now. A thing to note here is that if we integrate it to the project wide bootstrap, we'll need users to have virtualenv installed for mesos instead of only the CLI. - Haris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50910/#review145386 ----------------------------------------------------------- On Aug. 8, 2016, 10:10 p.m., Haris Choudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50910/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2016, 10:10 p.m.) > > > Review request for mesos, Kevin Klues and Vinod Kone. > > > Bugs: Mesos-6006 > https://issues.apache.org/jira/browse/Mesos-6006 > > > Repository: mesos > > > Description > ------- > > It currently doesn't run over any files in the code base, but we will > be adding the new python CLI in a subsequent commit, which will use > this new linter. > > > Diffs > ----- > > support/mesos-style.py 061cbe711bd9407b7341fa146f8c723eaa9fc438 > > Diff: https://reviews.apache.org/r/50910/diff/ > > > Testing > ------- > > > Thanks, > > Haris Choudhary > >
