----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51076/#review145704 -----------------------------------------------------------
Patch looks great! Reviews applied: [51074, 51075, 51076] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Aug. 13, 2016, 5:45 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51076/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2016, 5:45 p.m.) > > > Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and > Kevin Klues. > > > Bugs: MESOS-6020 > https://issues.apache.org/jira/browse/MESOS-6020 > > > Repository: mesos > > > Description > ------- > > Removed slavePid from the containerizer launch API. > > > Diffs > ----- > > src/slave/containerizer/composing.hpp > f3eebd19bc9e6b3b8a969a2ad967b3e2909e0ee4 > src/slave/containerizer/composing.cpp > 36d891792380abb01180ccc63cf2cd05b16b9620 > src/slave/containerizer/containerizer.hpp > b108d68aa05d80febcb4f6cc2ba3cc3183acda4f > src/slave/containerizer/containerizer.cpp > 2d59caf6555cb5866ef172d543c868e7f21c2f96 > src/slave/containerizer/docker.hpp 43ca4317d608b3b43dd7bd0d1b55c721e7364885 > src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62 > src/slave/containerizer/mesos/containerizer.hpp > 6585356543efe8794ff711e0ee251a2e13a6adc2 > src/slave/containerizer/mesos/containerizer.cpp > 86a8d8a85b6a33c87798108cb65af85bb9bbbc77 > src/slave/slave.hpp ffe4220c9289419ab1b1a2c1f499b6eac3c01e4b > src/slave/slave.cpp 29ca07a40d4e1d75979259cbe4f113baab37035b > src/tests/containerizer.hpp 76feedfdd381d92a1a19caca44e00630d7ecd281 > src/tests/containerizer.cpp 6f3950d0f4476d0872903b56dc2c7f95ae7e7ac5 > src/tests/containerizer/composing_containerizer_tests.cpp > e7619c15709e204d30fcc5b489873b5a8b717fab > src/tests/containerizer/filesystem_isolator_tests.cpp > 4d852ad6b14934ae7ec691cc124c77bda9bb2c8d > src/tests/containerizer/isolator_tests.cpp > 4f047ae6b2e85e177e8b73d60b9dfca913c832a5 > src/tests/containerizer/mesos_containerizer_tests.cpp > e3c8daab4fc688150a4f222e05f9b1bd9aee1912 > src/tests/hook_tests.cpp a1c8685d7ae984a728f5225cae89e3c235b46266 > src/tests/mesos.hpp 59688dc9d1b16f20facf272085e65b3835f9a56e > src/tests/slave_tests.cpp 787ec5b26fbf588a1148d2c54e03b93e7836de05 > > Diff: https://reviews.apache.org/r/51076/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
