----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51059/#review145809 -----------------------------------------------------------
Ship it! src/master/validation.cpp (line 590) <https://reviews.apache.org/r/51059/#comment212165> What will the final message be? If it's not being composed, then how about using 'ExecutorInfo.type' (and so on below) to describe the fields? - Benjamin Mahler On Aug. 15, 2016, 9:55 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51059/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2016, 9:55 p.m.) > > > Review request for mesos, Benjamin Mahler, James DeFelice, and Jie Yu. > > > Bugs: MESOS-6036 > https://issues.apache.org/jira/browse/MESOS-6036 > > > Repository: mesos > > > Description > ------- > > This is done to allow schedulers to use `ExecutorInfo` with just > `executor_id` set. This is a requirement for the upcoming support > for `TaskGroup` semantics. > > Note that in this patch, TASK_ERROR is returned when > `ExecutorInfo.command` is unset to keep the existing semantics for > `LAUNCH` offer operation. This might change when we add `LAUNCH_GROUP` > operation. > > > Diffs > ----- > > include/mesos/mesos.proto af29dab2af4c28e257ad518c68d3f1af7cad0d06 > include/mesos/v1/mesos.proto a836f6e792944726ec6f8f66f77f403894377d05 > src/master/validation.cpp af18e5aef3be59830b0a7b0235bbc739dba1029c > src/tests/master_validation_tests.cpp > 9eb82a569f7c48caa96d4d54a93b199ccac74385 > > Diff: https://reviews.apache.org/r/51059/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
