----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51130/#review145864 -----------------------------------------------------------
Patch looks great! Reviews applied: [51129, 51130] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Aug. 16, 2016, 4:23 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51130/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2016, 4:23 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6016 > https://issues.apache.org/jira/browse/MESOS-6016 > > > Repository: mesos > > > Description > ------- > > This change exposes the unversioned scheduler/executor protos > in the Mesos JAR. We already used to expose the unversioned > Mesos protos. This is useful for migrating schedulers to use > the new v1 API via the scheduler shim. Otherwise, they would > need to create their own copy of these protobufs even for vetting > the new API via the shim. Note that this only partially resolves > MESOS-6016 and that we would need to tackle the unversioned protobuf > deprecation later eventually. > > > Diffs > ----- > > src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 > > Diff: https://reviews.apache.org/r/51130/diff/ > > > Testing > ------- > > make check (verified the protos show up in the JAR) > > > Thanks, > > Anand Mazumdar > >
