----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50992/#review145892 -----------------------------------------------------------
Ship it! Have you been able to test this by compiling your module conditionally? include/mesos/version.hpp.in (line 24) <https://reviews.apache.org/r/50992/#comment212254> Ideally the TODO is to change the variables to integers after the deprecation cycles. - Jiang Yan Xu On Aug. 15, 2016, 10:31 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50992/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2016, 10:31 a.m.) > > > Review request for mesos, Xiaojian Huang, haosdent huang, James Peach, Joris > Van Remoortere, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-4638 > https://issues.apache.org/jira/browse/MESOS-4638 > > > Repository: mesos > > > Description > ------- > > This makes version based conditional compiling much easier for > module writers. > > > Diffs > ----- > > include/mesos/version.hpp.in c8fbc822d91abb61df15715c0c6af98b0bfe2cb9 > > Diff: https://reviews.apache.org/r/50992/diff/ > > > Testing > ------- > > make on Mac OS and Linux. > > > Thanks, > > Zhitao Li > >
